Another day another please break your PR that starts with "this PR does three things" into three PRs that do one thing.
@benc my biggest gripe with the GitHub Flow is that it’s so non-obvious how to review one commit at a time.
@benc One of the most productive engineers I've ever worked with, one of these mythical people who not only produces tons of great work but elevates the people and teams around him, would review code like 8-10x faster than anyone else around him, and when we finally sat down to watch how he worked, by far the biggest thing he did differently than anyone else was say "no" a lot earlier. "You're trying to do to much here, break this patch down." "You need to find a simpler way to do this."
@mhoye I've found a "lets do one thing at once" mindset good for untangling organisation in a few non-tech projects
@jon right. the most comfortable flow I found with @ParslProject + github is forced-squash-merge, review the PR knowing it becomes one commit, i don't care what your pre-merge history is.
It's awkward for submitting sequences that relate to each other but that is pretty rare in our project.